Bootstrap new preset Renovate config - #427
Conversation
cert-manager-prow
Bot
added
dco-signoff: yes
3afd2ac to
2ddaa86
Compare
2ddaa86 to
69ac93a
Compare
69ac93a to
6c9b1bb
Compare
6c9b1bb to
0ef1c13
Compare
0ef1c13 to
e962792
Compare
e962792 to
2c33326
Compare
2c33326 to
dfba5fc
Compare
f859dc9 to
319ac95
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
319ac95 to
ba95b4a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a bootstrap mechanism for Renovate configuration as part of migrating repositories to use a dedicated shared config preset. The change allows repositories to automatically receive a minimal Renovate config that extends from a centralized preset without overwriting existing configurations.
- Adds a bootstrap Renovate config file that extends from the shared preset
- Modifies the generate-base target to conditionally create the Renovate config
- Introduces module directory variable for better path management
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| renovate-bootstrap-config.json5 | New bootstrap config extending shared preset |
| 01_mod.mk | Enhanced generate-base target with conditional Renovate config creation |
| base/.github/renovate.json5 | Empty file addition for template structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if [ ! -e ./.github/renovate.json5 ]; then \ | ||
| mkdir -p ./.github; \ | ||
| cp $(_repository_base_module_dir)/renovate-bootstrap-config.json5 ./.github/renovate.json5; \ | ||
| fi |
There was a problem hiding this comment.
The shell command spans multiple lines without proper line continuation. Each line should end with a backslash (\) for proper make syntax, or the entire command should be on a single line with && separators.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ThatsMrTalbot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This PR prepares for the migration of repositories to use a dedicated repository as a Renovate shared config preset. A manual self-upgrade will be required to migrate a repository from the current Renovate config in repository-base module to the shared config preset repository for our org: https://github.com/cert-manager/renovate-config.
To implement this, I am proposing a solution where the Renovate config file is created if it does not already exist. It should never overwrite a config managed in the repo after bootstrap.
Tested here: cert-manager/webhook-cert-lib#78, which will also be the next repo to migrate to the new shared config. There are probably things missing from the new shared preset, so I think we should migrate slowly.